secretsmanagersecrets for oracle19c #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secretsmanagersecrets for oracle19c
wullub
force-pushed
the
secretsmanagersecrets-for-oracle19c
branch
from
e7f85d5 to
a800dcf
Compare
drobinson-moj
requested changes
Nov 3, 2023
robertsweetman
previously approved these changes
Nov 8, 2023
robertsweetman
approved these changes
Nov 8, 2023
drobinson-moj
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secretsmanagersecrets for oracle19c
reason:
sometimes secretsmanager is needed instead of ssm params. It has more features, e.g. sharing with other accounts. To keep everything consistent and simple, the dso team will use secretsmanager for all secrets
currently only changes the behaviour server_type_oasys_db
all other server types that use oracle-19c have
use_ssm_params: true
which means they don't use secretsmanager
testing:
tested on an ec2 running the oracle-19c role in oasys-test